Ticket #67 (closed enhancement: fixed)

Opened 4 years ago

Last modified 4 years ago

channel get/info is not enough

Reported by: thommey Owned by: pseudo
Priority: minor Milestone: 1.8.0
Component: Module: channels.mod Version: 1.8.0 CVS
Keywords: Cc:

Description (last modified by pseudo) (diff)

there's no way of knowing what channel settings are available (think udefs)

Change History

comment:1 Changed 4 years ago by pseudo

  • Owner changed from thommey to pseudo
  • Status changed from new to assigned

I suggest a getudef command with an optional argument to specify the type to list. Without arguments, it should list all available udef settings.

comment:2 follow-up: ↓ 3 Changed 4 years ago by pseudo

  • Status changed from assigned to closed
  • Type changed from defect to enhancement
  • Resolution set to fixed

Done. I've made the following changes:

[channel get #chan] (without setting argument) gives all settings and their values
[getudefs ?type?] returns all udefs, filtered by type, if given.
[chansettype setting] returns the type of a built-in or user defined setting (int/str/flag/pair)

comment:3 in reply to: ↑ 2 ; follow-ups: ↓ 4 ↓ 6 Changed 4 years ago by Robby

  • Status changed from closed to reopened
  • Resolution fixed deleted

Replying to pseudo:

[channel get #chan] (without setting argument) gives all settings and their values

For udefs the value is not given in the output, what does appear is what type they are. I don't know if this is intended to be this way (I actually think not, reading what you said that it should return the current values this seems more like a bug), but it would seem more uniform/correct with respect to the other built-in settings that it should return the value instead of the type.

comment:4 in reply to: ↑ 3 Changed 4 years ago by pseudo

  • Status changed from reopened to closed
  • Resolution set to fixed
  • Description modified (diff)

Replying to Robby:

Replying to pseudo:

[channel get #chan] (without setting argument) gives all settings and their values

For udefs the value is not given in the output, what does appear is what type they are. I don't know if this is intended to be this way (I actually think not, reading what you said that it should return the current values this seems more like a bug), but it would seem more uniform/correct with respect to the other built-in settings that it should return the value instead of the type.

comment:5 Changed 4 years ago by pseudo

  • Description modified (diff)

comment:6 in reply to: ↑ 3 Changed 4 years ago by pseudo

Yeah, you're right. I fixed this.

Thanks for testing 1.8 thoroughly, that's the kind of feedback we've been hoping for. :)

Note: See TracTickets for help on using tickets.